Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141676828
--- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
@@ -66,6 +66,13 @@ class TaskInfo(
*/
var finishTime: Long = 0
+ /**
+ * Set this var when the current task killed by other attempt tasks,
this happened while we
+ * set the `spark.speculation` to true. The task killed by others should
not resubmit
+ * while executor lost.
+ */
+ var killedByOtherAttempt = false
--- End diff --
`TaskInfo` is a little funny since its DeveloperApi. Its exposed to the
user via SparkListener events. If want to leave it publicly visible, then I
think there should only be a getter, not a public `var`, and also we'd need to
update the way its converted to / from json in
`o.a.s.util.JsonProtocol.taskInfoToJson` etc. But I think its perhaps better
to just mark this as `private[scheduler]`, as I dont' think its actually
important for the end user.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
