Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19287#discussion_r141677782
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskInfo.scala ---
    @@ -66,6 +66,13 @@ class TaskInfo(
        */
       var finishTime: Long = 0
     
    +  /**
    +   * Set this var when the current task killed by other attempt tasks, 
this happened while we
    +   * set the `spark.speculation` to true. The task killed by others should 
not resubmit
    +   * while executor lost.
    +   */
    +  var killedByOtherAttempt = false
    --- End diff --
    
    actually, I had another thought -- rather than putting this info in 
`TaskInfo`, I think its more natural to add something totally private to 
`TaskSetManager`:
    
    `private val killedByOtherAttempt: Array[Boolean]`
    



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to