Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/19287#discussion_r141668660
--- Diff: core/src/test/scala/org/apache/spark/scheduler/FakeTask.scala ---
@@ -58,4 +57,18 @@ object FakeTask {
}
new TaskSet(tasks, stageId, stageAttemptId, priority = 0, null)
}
+
+ def createShuffleMapTaskSet(numTasks: Int, stageId: Int, stageAttemptId:
Int,
+ prefLocs: Seq[TaskLocation]*): TaskSet = {
--- End diff --
nit: multi-line method definitions should have each param on its own line,
indented 4 spaces
```scala
def createShuffleMapTaskSet(
numTasks: Int,
stageId: Int,
stageAttemptId: Int,
prefLocs: Seq[TaskLocation]*): TaskSet = {
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
