Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19981#discussion_r158171335
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLHistoryServerPlugin.scala
 ---
    @@ -0,0 +1,34 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution.ui
    +
    +import org.apache.spark.SparkConf
    +import org.apache.spark.scheduler.SparkListener
    +import org.apache.spark.status.{AppHistoryServerPlugin, 
ElementTrackingStore}
    +import org.apache.spark.ui.SparkUI
    +
    +class SQLHistoryServerPlugin extends AppHistoryServerPlugin {
    +  override def createListeners(conf: SparkConf, store: 
ElementTrackingStore): Seq[SparkListener] = {
    +    Seq(new SQLAppStatusListener(conf, store, live = false))
    +  }
    +
    +  override def setupUI(ui: SparkUI): Unit = {
    +    val kvStore = ui.store.store
    +    new SQLTab(new SQLAppStatusStore(kvStore), ui)
    --- End diff --
    
    You shouldn't be adding the UI if there is no SQL-related data in the store.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to