Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20462#discussion_r165244212
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
@@ -112,7 +112,7 @@ void monitorChild() {
}
}
- disconnect();
+ dispose();
--- End diff --
Can we add more document to `disconnect` and `dispose`? So that people can
understand the difference between them clearly and have a better understanding
of changes like this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
