Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20462#discussion_r165247921
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java ---
@@ -363,17 +362,28 @@ public void close() throws IOException {
/**
* Close the connection and wait for any buffered data to be processed
before returning.
--- End diff --
according to the document, shall we still call it `closeAndWait`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
