Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20462#discussion_r165248266
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/InProcessAppHandle.java ---
@@ -66,7 +66,7 @@ synchronized void start(String appName, Method main,
String[] args) {
setState(State.FAILED);
}
- disconnect();
+ dispose();
--- End diff --
If we call `disconnect` here, we would close the connection, and then wait
the close to finish in `dispose`. If we call `dispose` directly, we also close
and wait the connection(in `waitForClose`). What the actual difference here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
