Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20462#discussion_r165245465
  
    --- Diff: 
launcher/src/main/java/org/apache/spark/launcher/ChildProcAppHandle.java ---
    @@ -112,7 +112,7 @@ void monitorChild() {
             }
           }
     
    -      disconnect();
    +      dispose();
    --- End diff --
    
    `disconnect()` is actually a public method and already documented in the 
SparkAppHandle interface.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to