Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21026#discussion_r180554710
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ---
    @@ -331,7 +333,7 @@ class CodegenContext {
           case _: StructType | _: ArrayType | _: MapType => s"$value = 
$initCode.copy();"
           case _ => s"$value = $initCode;"
         }
    -    ExprCode(code, FalseLiteral, GlobalValue(value, javaType(dataType)))
    +    ExprCode.forNonNullValue(JavaCode.global(value, dataType))
    --- End diff --
    
    oops


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to