Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180575717
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -292,8 +292,7 @@ object GenerateUnsafeProjection extends
CodeGenerator[Seq[Expression], UnsafePro
|$writeExpressions
""".stripMargin
// `rowWriter` is declared as a class field, so we can access it
directly in methods.
- ExprCode(code, FalseLiteral, StatementValue(s"$rowWriter.getRow()",
"UnsafeRow",
- canDirectAccess = true))
+ ExprCode(code, FalseLiteral, SimpleExprValue(s"$rowWriter.getRow()",
classOf[UnsafeRow]))
--- End diff --
Add a `JavaCode.expression(expr: String, javaClass: Class[_])` and use it
here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
