Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180596423
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -352,12 +346,10 @@ case class IsNotNull(child: Expression) extends
UnaryExpression with Predicate {
override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
val eval = child.genCode(ctx)
- val value = if (eval.isNull == TrueLiteral) {
- FalseLiteral
- } else if (eval.isNull == FalseLiteral) {
- TrueLiteral
- } else {
- StatementValue(s"(!(${eval.isNull}))",
CodeGenerator.javaType(dataType))
+ val value = eval.isNull match {
+ case TrueLiteral => FalseLiteral
+ case FalseLiteral => TrueLiteral
+ case v => JavaCode.isNullExpression(s"!($v)")
--- End diff --
I think we can remove the parens here. `SimpleExprValue` guarantees this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
