Github user rednaxelafx commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21026#discussion_r180575964
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateSafeProjection.scala
 ---
    @@ -76,7 +78,7 @@ object GenerateSafeProjection extends 
CodeGenerator[Seq[Expression], Projection]
              |final InternalRow $output = new $rowClass($values);
            """.stripMargin
     
    -    ExprCode(code, FalseLiteral, VariableValue(output, "InternalRow"))
    +    ExprCode(code, FalseLiteral, VariableValue(output, 
classOf[InternalRow]))
    --- End diff --
    
    Use `JavaCode.variable(name, javaClass)` here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to