Github user ryan-williams commented on the pull request:
https://github.com/apache/spark/pull/2848#issuecomment-65827581
Thanks for the review pass, @JoshRosen.
As I mentioned in some of the comments, this was attempting to shoehorn 4
basically-identical blocks of code from elsewhere in this file into one common
code path (it started with 1 or 2 and then grew to encompass the others as
previous reviewers suggested that that was desirable).
The PR has been mostly sitting around for many weeks and apparently one of
the maintenance merges I did removed some key bits; I'll fix those and bump
this again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
