Github user ryan-williams commented on a diff in the pull request: https://github.com/apache/spark/pull/2848#discussion_r21389032 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -412,6 +403,48 @@ private[spark] object Utils extends Logging { } /** + * Download a file from @in to @tempFile, then move it to @destFile, checking whether @destFile + * already exists, is equal to the downloaded file, and can be overwritten. + */ + private def maybeMoveFile( + url: String, + sourceFile: File, + destFile: File, + fileOverwrite: Boolean): Unit = { + + var shouldCopy = true + if (destFile.exists) { + if (!Files.equal(sourceFile, destFile)) { + if (fileOverwrite) { + destFile.delete() + logInfo(("File %s exists and does not match contents of %s, " + + "replacing it with %s").format(destFile, url, url)) --- End diff -- on reading it again, I think the original code (that predates me) made sense: it asserting that the file exists and does not match `url`, therefore we are replacing the thing that already exists with what is at `url`, because that is what we want it to match.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org