Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/2848#discussion_r21501367 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -412,6 +408,85 @@ private[spark] object Utils extends Logging { } /** + * Download a file from `in` to `tempFile`, then move it to `destFile`, checking whether + * `destFile` already exists, has the same contents as the downloaded file, and can be + * overwritten. + * + * @param url URL that `sourceFile` originated from, for logging purposes. + * @param in InputStream to download. + * @param tempFile File path to download `in` to. + * @param destFile File path to move `tempFile` to. + * @param fileOverwrite Whether to delete/overwrite an existing `destFile` that does not match + * `sourceFile` + */ + private def downloadStreamAndMove( + url: String, --- End diff -- Fairly minor style nit, but do you mind indenting these method parameters by two more spaces, like `fetchFile` above: ``` def fetchFile( url: String, targetDir: File, conf: SparkConf, securityMgr: SecurityManager, hadoopConf: Configuration, timestamp: Long, useCache: Boolean) { val fileName = url.split("/").last ``` This is a really minor style point that I've been guilty of overlooking myself: https://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org