Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4067#discussion_r23065562
--- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
---
@@ -134,6 +149,30 @@ class TaskMetrics extends Serializable {
}
/**
+ * Returns the input metrics object that the task should use. Currently,
if
+ * there exists an input metric with the same readMethod, we return that
one
+ * so the caller can accumulate bytes read. If the readMethod is
different
+ * than previously seen by this task, we return a new InputMetric but
don't
+ * record it.
+ *
+ * Once https://issues.apache.org/jira/browse/SPARK-5225 is addressed,
+ * we can store all the different inputMetrics (one per readMethod).
+ */
+ private[spark] def getInputMetricsForReadMethod(readMethod:
DataReadMethod):
--- End diff --
```scala
private[spark] def getInputMetricsForReadMethod(readMethod:
DataReadMethod): InputMetrics =
synchronized {
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
