Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4067#discussion_r23065952
--- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
---
@@ -179,10 +223,48 @@ object DataWriteMethod extends Enumeration with
Serializable {
*/
@DeveloperApi
case class InputMetrics(readMethod: DataReadMethod.Value) {
+
+ private val _bytesRead: AtomicLong = new AtomicLong()
+ private val _recordsRead: AtomicLong = new AtomicLong()
+
/**
* Total bytes read.
*/
- var bytesRead: Long = 0L
+ def bytesRead: Long = _bytesRead.get()
+
+ /**
+ * Total records read.
+ */
+ def recordsRead: Long = _recordsRead.get()
+ @volatile @transient var bytesReadCallback: Option[() => Long] = None
+
+ /**
+ * Adds additional bytes read for this read method.
+ */
+ def addBytesRead(bytes: Long) = {
+ _bytesRead.addAndGet(bytes)
+ }
+
+ def addRecordsRead(records: Long) = {
--- End diff --
maybe incrementRecordsRead and incrementBytesRead are better names?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
