Github user ksakellis commented on the pull request:
https://github.com/apache/spark/pull/4067#issuecomment-70218640
@rxin I updated the PR after doing a rebase and also incorporated some of
your feedback. You made two general comments:
1) specific implementations might've gone a bit over board with Scala
language features
2) too many new classes introduced
Can you please be more specific here pointing to the specific code. These
comments are not very actionable as is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
