Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/4067#issuecomment-70215975
Hey @ksakellis - Thanks for working on this.
I took a very quick look at the patch. Overall I feel the patch should be
fairly straightforward, but the specific implementations might've gone a bit
over board with Scala language features (a lot of Options, orElse, closures,
etc) and design (too many new classes introduced). If we can reduce those, the
pr would be a lot easier to understand.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
