amanomer commented on a change in pull request #26454: [SPARK-29818][MLLIB]
Missing persist on RDD
URL: https://github.com/apache/spark/pull/26454#discussion_r344718067
##########
File path: mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala
##########
@@ -141,8 +141,10 @@ class CrossValidator @Since("1.2.0") (@Since("1.4.0")
override val uid: String)
Some(Array.fill($(numFolds))(Array.fill[Model[_]](epm.length)(null)))
} else None
+ val inputRDD = dataset.toDF.rdd
+ inputRDD.persist()
Review comment:
I think, here persist is required? Since training and testing datasets are
dependent on them and in further code, these datasets have been used
repeatedly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
