amanomer commented on a change in pull request #26454: [SPARK-29818][MLLIB]
Missing persist on RDD
URL: https://github.com/apache/spark/pull/26454#discussion_r345570774
##########
File path:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala
##########
@@ -138,6 +138,7 @@ final class EMLDAOptimizer extends LDAOptimizer {
this.docConcentration = if (docConcentration == -1) (50.0 / k) + 1.0 else
docConcentration
this.topicConcentration = if (topicConcentration == -1) 1.1 else
topicConcentration
val randomSeed = lda.getSeed
+ docs.persist()
Review comment:
`docs` is user input hence persist not required.
https://github.com/apache/spark/blob/80fbc382a60973db21367a922a0fb797e5ab382d/mllib/src/main/scala/org/apache/spark/mllib/clustering/LDA.scala#L331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
