amanomer commented on a change in pull request #26454: [SPARK-29818][MLLIB]
Missing persist on RDD
URL: https://github.com/apache/spark/pull/26454#discussion_r345569151
##########
File path:
mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala
##########
@@ -122,6 +122,7 @@ private[spark] object RandomForest extends Logging with
Serializable {
timer.start("init")
val retaggedInput = input.retag(classOf[Instance])
+ retaggedInput.persist()
Review comment:
> We add these internal persist calls for important partial results though,
not user inputs, in general, and only if the user input was cached.
`retaggedInput` is just transformed user data (`input`) and further its
partial result (`baggedInput`) is persisted at line 158.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
