amanomer commented on a change in pull request #26454: [SPARK-29818][MLLIB]
Missing persist on RDD
URL: https://github.com/apache/spark/pull/26454#discussion_r345573321
##########
File path: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
##########
@@ -217,6 +217,7 @@ object PrefixSpan extends Logging {
data: RDD[Array[Array[Item]]],
minCount: Long): Array[Item] = {
+ data.persist()
Review comment:
Just an user input, therefore persist not required. Its only caller
https://github.com/apache/spark/blob/80fbc382a60973db21367a922a0fb797e5ab382d/mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala#L146
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
