pan3793 commented on code in PR #4726:
URL: https://github.com/apache/zeppelin/pull/4726#discussion_r1526236055
##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepo.java:
##########
@@ -33,7 +35,7 @@
*/
public interface NotebookRepo extends Closeable {
- void init(ZeppelinConfiguration zConf) throws IOException;
+ void init(ZeppelinConfiguration zConf, Gson gson) throws IOException;
Review Comment:
I think this is a public API, and users may have custom implementations,
such change will break them. Additionally, we'd better avoid leaking the
third-party lib classes as much as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
