Reamer commented on code in PR #4726:
URL: https://github.com/apache/zeppelin/pull/4726#discussion_r1531850950
##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepo.java:
##########
@@ -33,7 +35,7 @@
*/
public interface NotebookRepo extends Closeable {
- void init(ZeppelinConfiguration zConf) throws IOException;
+ void init(ZeppelinConfiguration zConf, Gson gson) throws IOException;
Review Comment:
Very good advice. I have wrapped the parser `NoteParser` in its own
interface. It should now be possible to implement a custom parser easily. The
implementation of the interface must of course be done by the people who don't
want the default (`GsonNoteParser`).
GSON will not become more widespread with the change and we can also switch
more easily via this interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
