pan3793 commented on code in PR #4726:
URL: https://github.com/apache/zeppelin/pull/4726#discussion_r1526249570
##########
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterOption.java:
##########
@@ -30,7 +30,6 @@ public class InterpreterOption {
public static final transient String SHARED = "shared";
public static final transient String SCOPED = "scoped";
public static final transient String ISOLATED = "isolated";
- private static ZeppelinConfiguration conf = ZeppelinConfiguration.create();
Review Comment:
how about converting this static field from `static` to a member field? then
we don't need to change the signature of `getOwners` method.
some thoughts: current change is `inconsistent`, only part of `getXXX`
methods require `conf` parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
