pan3793 commented on code in PR #4726:
URL: https://github.com/apache/zeppelin/pull/4726#discussion_r1526252760
##########
zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java:
##########
@@ -117,37 +118,25 @@ private void loadXMLConfig(@Nullable String filename)
throws ConfigurationExcept
}
}
- public static ZeppelinConfiguration create() {
- if (conf != null) {
- return conf;
- }
- return ZeppelinConfiguration.create(null);
+ public static ZeppelinConfiguration load() {
Review Comment:
I see the impl change, but what's the benefit of renaming method `create` to
`load`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
