Reamer commented on code in PR #4902:
URL: https://github.com/apache/zeppelin/pull/4902#discussion_r2038841092
##########
zeppelin-client/pom.xml:
##########
@@ -48,7 +48,7 @@
<dependency>
<groupId>org.eclipse.jetty.websocket</groupId>
- <artifactId>websocket-client</artifactId>
+ <artifactId>websocket-jetty-client</artifactId>
Review Comment:
The Zeppelin client uses its own Jetty implementation. My main goal of this
pull request was to move away from `javax.` and towards `jakarta.`.
In my opinion, rewriting to a Jakarta implementation for the client is part
of a different requirement.
##########
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java:
##########
@@ -207,7 +206,8 @@ protected void configure() {
.to(RemoteInterpreterProcessListener.class)
.to(ApplicationEventListener.class)
.to(NoteEventListener.class)
- .to(WebSocketServlet.class)
+ // TODO: check
+ // .to(WebSocketServlet.class)
Review Comment:
The `NotebookServer` is used in the rest classes. Example classes are
`NotebookRepoRestApi` and `InterpreterRestApi`.
However, we never use an object of the class `WebSocketServlet`, but always
an object of our class `NotebookServer`.
The `NotebookServer` is still a Singleton. Therefore, no more than one
object should be created.
The `NotebookServer` class itself does not provide a rest endpoint and is
therefore not initiated when the rest service is started.
https://github.com/apache/zeppelin/blob/d95f43a3581c11b2673b5a04431f40556d9fe8ab/zeppelin-server/src/main/java/org/apache/zeppelin/server/RestApiApplication.java#L37-L57
Have I reached the right conclusions? What do you think? I have removed the
TODO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
