jongyoul commented on code in PR #4902:
URL: https://github.com/apache/zeppelin/pull/4902#discussion_r2041388864
##########
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java:
##########
@@ -207,7 +206,8 @@ protected void configure() {
.to(RemoteInterpreterProcessListener.class)
.to(ApplicationEventListener.class)
.to(NoteEventListener.class)
- .to(WebSocketServlet.class)
+ // TODO: check
+ // .to(WebSocketServlet.class)
Review Comment:
Yes, you're right about the rest servlet. :-) What I mentioned is about
cross-servlet singlton object. NotebookServer is being used both in rest and
websocket, and they created their instances separately, so NotebookServer is a
singletone in each servlet, but in an application level, we have two different
NotebookServers for rest and websocket servlets.
My concern is whether we can use broadcast methods properly. NotebookServer,
located in WebSocket servlet, stores the socket information for users. RestAPI
uses the information to broadcast paragraphs and notes. If it works as it is, I
think it should be ok.
By the way, it was almost four years ago, so please correct me if I'm wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
