Reamer commented on code in PR #4902:
URL: https://github.com/apache/zeppelin/pull/4902#discussion_r2046509971
##########
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java:
##########
@@ -207,7 +206,8 @@ protected void configure() {
.to(RemoteInterpreterProcessListener.class)
.to(ApplicationEventListener.class)
.to(NoteEventListener.class)
- .to(WebSocketServlet.class)
+ // TODO: check
+ // .to(WebSocketServlet.class)
Review Comment:
My manual tests have produced the following log lines. In my opinion, this
ensures that there are no two objects from the NotebookServer class.
```
WARN [2025-04-16 11:24:06,240] ({qtp1516500233-49}
InterpreterRestApi.java[listSettings]:102) - NotebookServerClass:
org.apache.zeppelin.socket.NotebookServer@10b892d5
WARN [2025-04-16 11:24:16,230] ({qtp1516500233-49}
NotebookServer.java[onMessage]:278) - NotebookServerClass:
org.apache.zeppelin.socket.NotebookServer@10b892d5
WARN [2025-04-16 11:24:26,287] ({qtp1516500233-49}
NotebookServer.java[onMessage]:278) - NotebookServerClass:
org.apache.zeppelin.socket.NotebookServer@10b892d5
WARN [2025-04-16 11:24:37,003] ({qtp1516500233-38}
NotebookServer.java[onMessage]:278) - NotebookServerClass:
org.apache.zeppelin.socket.NotebookServer@10b892d5
WARN [2025-04-16 11:24:47,614] ({qtp1516500233-55}
NotebookServer.java[onMessage]:278) - NotebookServerClass:
org.apache.zeppelin.socket.NotebookServer@10b892d5
INFO [2025-04-16 11:24:56,656] ({qtp1516500233-23}
NotebookRepoRestApi.java[listRepoSettings]:76) - Getting list of NoteRepo with
Settings for user anonymous
WARN [2025-04-16 11:24:56,656] ({qtp1516500233-23}
NotebookRepoRestApi.java[listRepoSettings]:77) - NotebookServerClass:
org.apache.zeppelin.socket.NotebookServer@10b892d5
```
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
