Reamer commented on code in PR #4902:
URL: https://github.com/apache/zeppelin/pull/4902#discussion_r2041642113
##########
zeppelin-server/src/main/java/org/apache/zeppelin/server/ZeppelinServer.java:
##########
@@ -207,7 +206,8 @@ protected void configure() {
.to(RemoteInterpreterProcessListener.class)
.to(ApplicationEventListener.class)
.to(NoteEventListener.class)
- .to(WebSocketServlet.class)
+ // TODO: check
+ // .to(WebSocketServlet.class)
Review Comment:
I understand. The correct behaviour is not obvious to me in the code,
because I don't have such a deep understanding either. I will therefore simply
carry out a practical test.
```patch
git diff
diff --git
a/zeppelin-server/src/main/java/org/apache/zeppelin/rest/InterpreterRestApi.java
b/zeppelin-server/src/main/java/org/apache/zeppelin/rest/InterpreterRestApi.java
index 00158d330..4c40b747f 100644
---
a/zeppelin-server/src/main/java/org/apache/zeppelin/rest/InterpreterRestApi.java
+++
b/zeppelin-server/src/main/java/org/apache/zeppelin/rest/InterpreterRestApi.java
@@ -99,6 +99,7 @@ public class InterpreterRestApi extends AbstractRestApi {
@Path("setting")
@ZeppelinApi
public Response listSettings() {
+ LOGGER.warn("NotebookServerClass: {}", notebookServer);
return new JsonResponse<>(Status.OK, "",
interpreterSettingManager.get()).build();
}
diff --git
a/zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRepoRestApi.java
b/zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRepoRestApi.java
index 187eb3a32..52fb25873 100644
---
a/zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRepoRestApi.java
+++
b/zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRepoRestApi.java
@@ -74,6 +74,7 @@ public class NotebookRepoRestApi extends AbstractRestApi {
public Response listRepoSettings() {
AuthenticationInfo subject = new
AuthenticationInfo(authenticationService.getPrincipal());
LOGGER.info("Getting list of NoteRepo with Settings for user {}",
subject.getUser());
+ LOGGER.warn("NotebookServerClass: {}", notebookWsServer);
List<NotebookRepoWithSettings> settings =
noteRepos.getNotebookRepos(subject);
return new JsonResponse<>(Status.OK, "", settings).build();
}
diff --git
a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
index 57dade43c..d63b1b691 100644
---
a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
+++
b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
@@ -274,6 +274,9 @@ public class NotebookServer implements
AngularObjectRegistryListener,
public void onMessage(NotebookSocket conn, String msg) {
try {
Message receivedMessage = deserializeMessage(msg);
+ if (receivedMessage.op == OP.PING) {
+ LOGGER.warn("NotebookServerClass: {}", this);
+ }
if (receivedMessage.op != OP.PING) {
LOGGER.debug("RECEIVE: " + receivedMessage.op +
", RECEIVE PRINCIPAL: " + receivedMessage.principal +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
