On 5/9/06, David M Johnson <[EMAIL PROTECTED]> wrote:

On May 9, 2006, at 7:34 PM, Matt Raible wrote:
> On 5/9/06, David M Johnson <[EMAIL PROTECTED]> wrote:
>> On May 9, 2006, at 6:01 PM, Matt Raible wrote:
>> > My modifications to the *.vm templates fix JavaScript and CSS
>> issues -
>> > should those go in 2.3 or 2.4?
>> I've already found 1 problem in RC2, so they could conceivably go in
>> 2.3.
>> How extensive and how risky are those *.vm changes?
>
> I've attached the patch so you can see.  The only major thing is a new
> form for comments that more CSS-friendly. Other things include new
> macros and fixing comments HTML so it renders with XHTML
> compliance. I also fixed a bug in the JavaScript for Remember Me
> (only happens
> with IE).

Hmmm... I think we should consider that for 2.4. However, I don't
like the idea of introducing another comment form macro. We already
have two (regular and twisty-style) and we should really have just
one. Can we change the existing comment form macro to make it CSS
compliant/friendly instead?


> I've successfully upgraded a site from 2.0 to 2.3 RC2 today, but I
> have noticed an issue with the LineBreak Plugin.  As soon as it's
> added to an entry, the entry cannot be rendered and there's no way of
> getting it back - even though it's stored in the database and renders
> in the editor. Below is an example.
>
> http://virtuastravels.com/page/road?entry=a_federal_incident_8230
>
> Any ideas?

That plugin works for me, so I bet  the problem is this: your roller-
custom.properties override file is still using the old org.roller
package names for the plugins. Change those to org.apach.roller and I
bet you'll be in business.

In my roller-custom.properties, all I have configured is:

uploads.dir=
search.index.dir=
editor.theme=

It might be that my custom weblog.vm is causing problems, but I don't
think so.  It's strange that the entry renders fine, but after
editing, it just says "null".

Matt


- Dave


Reply via email to