On Sunday 05 Sep 2004 10:53, Guillaume Laurent wrote:
> On Sunday 05 September 2004 09:56, Silvan wrote:
> > I'll leave it between you and Guillaume to duke it out over whether we
> > want to up the ante and demand 3.2 now.
>
> I don't know how widely 3.1 is still used, really. That Rich still uses it
> would indicate that requiring 3.2 is still a bit premature

I still use it too.  And so do you, it seems, in your nightly build scripts, 
which failed last night for want of this header.

I'm building just now on my 3.2 box, but I have to say that I'm not happy with 
the sound of this -- it sounds like a new feature to me, not at all just a 
fix for an evident bug.  The focus on font family sounds like a red herring 
as well, really -- we ought to be able to tell Qt to use "a serif font" at a 
given size and it really ought to work, at least when Qt is using 
Xft/fontconfig underneath (which it almost always is these days).  What 
you're doing here sounds like a user-operated workaround, not a fix.

> Yes, I see that too. I was so focused on printing that it completely
> escaped me. Actually the reason may be because we're misusing QFontMetrics.
> We always use it the QFontMetric(QFont) ctor, but according to the docs we
> should be using QPainter::fontMetrics().

Huh?  Why?  QPainter::fontMetrics gets you a metrics object for the font 
currently used by the panter, and if the painter's font changes, your metrics 
object updates itself accordingly.  (IIRC -- I haven't checked the docs 
here.)  QFontMetric(QFont) should still provide you a valid metrics object 
for a given font.

> However that's not compatible with 
> the way we create text pixmaps, since we use the font metrics to determine
> the size of the pixmap we're going to draw the text on in the first place.

Quite.

> Forget the point size, it's irrelevant in this situation. The font
> requester is only used to set a font family actually, the choosen size is
> ignored (not perfect I know, but still manageable).

Another reason this sounds like a nasty workaround stroke new feature, rather 
than a bug fix.

Anyway, when it's built I might have more to contribute.  Either way this 
sounds like a reasonable way to test one font against another, should provide 
some evidence if nothing else.


Chris


-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
_______________________________________________
Rosegarden-devel mailing list
[EMAIL PROTECTED] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-devel

Reply via email to