@dmnks commented on this pull request.
> @@ -168,10 +179,8 @@ rpmRC keystore_fs::import_key(rpmtxn txn, rpmPubkey key,
> int replace, rpmFlags f
if (!rc && replace) {
/* find and delete the old pubkey entry */
- if (delete_key(txn, fp, keyfmt) == RPMRC_NOTFOUND) {
- /* make sure an old, short keyid version gets removed */
- delete_key(txn, fp.substr(32), keyfmt);
- }
+ newname = keyfmt;
I'm thinking that maybe we should reset this property after calling
delete_key() below (and the same with the rpmdb implementation). While the
typical lifetime of a keystore object is for one rpmkeys invocation,
technically the API doesn't prevent one from doing e.g. an import and then a
delete using the same instance.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4005#pullrequestreview-3338623018
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4005/review/[email protected]>_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint
