@pmatilai commented on this pull request.
> @@ -124,6 +123,19 @@ static rpmRC delete_file_store(std::string path)
return RPMRC_OK;
}
+/* Friend wrapper for private delete_key() that falls back to short key IDs */
+static rpmRC rpm::delete_key(auto keystore, rpmtxn txn, rpmPubkey key, auto
skip)
This is cosmetical of course, but I'd use a different name to differentiate
from the actual methods, and suggest a reason for its existence. Eg.
delete_key_compat() is not a great name but suggests there's something to do
with compatibility.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4005#pullrequestreview-3349348634
You are receiving this because you are subscribed to this thread.
Message ID: <rpm-software-management/rpm/pull/4005/review/[email protected]>_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint
