@dmnks commented on this pull request.


> @@ -168,10 +179,8 @@ rpmRC keystore_fs::import_key(rpmtxn txn, rpmPubkey key, 
> int replace, rpmFlags f
 
     if (!rc && replace) {
        /* find and delete the old pubkey entry */
-       if (delete_key(txn, fp, keyfmt) == RPMRC_NOTFOUND) {
-           /* make sure an old, short keyid version gets removed */
-           delete_key(txn, fp.substr(32), keyfmt);
-       }
+       newname = keyfmt;

Alternatively, we could keep the original, private delete_key() variant that 
takes a third parameter, instead of using an object property. It would just 
make it a bit more ugly...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/4005#discussion_r2431315721
You are receiving this because you are subscribed to this thread.

Message ID: <rpm-software-management/rpm/pull/4005/review/[email protected]>
_______________________________________________
Rpm-maint mailing list
[email protected]
https://lists.rpm.org/mailman/listinfo/rpm-maint

Reply via email to