https://bugzilla.rpmfusion.org/show_bug.cgi?id=5155

Nicolas Chauvet <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review+              |

--- Comment #32 from Nicolas Chauvet <[email protected]> ---
There are many issues and miss-understanding with this review.
Just withdrawn the package approval to describe the current state.

The approval to use fdk-aac from the nonfree section doesn't apply to the
fdk-aac-free yet because it's unclear if this package is legally usable even
within fedora. I don't think any (even LGPL) software enable fdk-aac-free in
Fedora yet.

Also we might have some issue as it's not updated to the current 2.0 version,
so we will build with the older fdk-aac-free 1x wheras we might use fdk-aac 2.0
from the nonfree repo and might lead to unfixable issue.
(even in the project works with fdk-aac-free, the way it's design is to be able
to replace with the full-featured version at runtime).

About the legal aspect:
When I've asked to send an email to [email protected] I've only received one
from the "Downstream" EHfive project. Thanks for that.
But when I meant upstream, I really meant at least both PulseAudio (LGPL) and
Bluetooth (GPL) maintainers, because this project links with both.

But really this is really a messy computation and I'm not really sure who and
how anyone can approve that.
->-> Best would be to develop and alternative to use the internal FFmpeg AAC
implementation.


>From the packaging front:
A side point also is that I disagree on the "Macro-ify factorisation contest"
Please consider to drop macros that are will not vary from the package
lifetime.
This make it harder to read the spec file.

Also I don't get why to have Recommends when you are expected to link to theses
libraries. If you link to ffmpeg, libldac of fdk-aac, there is no point to
recommends them because they will be made mandatory by the RPM dependency
computation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
rpmfusion-developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to