https://bugzilla.rpmfusion.org/show_bug.cgi?id=5155
Nicolas Chauvet <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
namespace|nonfree |free
--- Comment #37 from Nicolas Chauvet <[email protected]> ---
Few minor issues:
- I think you can drop upstream_version and set 1.1 in the Version field
instead.
- If ordering of macros matters (to be declared before used for more clarity).
I would suggest to move the macros definition before the Source0 (or
conflict/provides)
- It is more usual to have conflicts/provides after the mandatory Source0 field
(but it's more cosmetic)
- On Obsoletes/Provides,
- You can drop the %{dist} as it's not relevant (the release field might be
higher in the PA package to make the dist macro relevant)
- Obsoleles needs to be strictly lower than. Provides is equal
- You probably need to bump release to 100 for both conflicts and provides
- On Recommends:
I'm still not sure if they are relevant. Usually the libraries are linked at
build time, so they are also mandatory at runtime. RPM detects them, so you are
not required to mention theses dependencies.
But it's possible that theses libraries aren't linked and are using dlopen
instead. Which means this Recommends would make sense.
- Last point, the project is written RPM Fusion if case sensitive or when no
space is allowed rpmfusion. (from your changelog).
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
rpmfusion-developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]
