https://bugzilla.rpmfusion.org/show_bug.cgi?id=7470
Nicolas Chauvet <[email protected]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|rpmfusion-package-review@rp |[email protected]
|mfusion.org |
--- Comment #1 from Nicolas Chauvet <[email protected]> ---
Here is a formal review:
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- The License field must be a valid SPDX expression.
Note: Not a valid SPDX expression 'Proprietary AND GPL-2.0-or-later'.
See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1
- Packages have proper BuildRequires/Requires on javapackages-tools
(jpackage-utils)
- Javadoc documentation files are generated and included in -javadoc
subpackage
Note: No javadoc subpackage present. Note: Javadocs are optional for
Fedora versions >= 21
See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Note: No javadoc subpackage present
See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
- Bundled jar/class files should be removed before build
Note: Jar files in source (see attachment)
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/Java/#_pre_built_dependencies
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[-]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "FSF Unlimited License [generated
file]", "GNU General Public License v3.0 or later", "X11 License
[generated file]", "GNU General Public License v2.0 or later", "GNU
General Public License, Version 2", "*No copyright* GNU General Public
License, Version 2", "OpenSSL License", "Apache License 1.0 and/or
OpenSSL License", "*No copyright* Public domain", "GNU Lesser General
Public License v2.1 or later", "GNU General Public License (v2 or
later) or GNU Lesser General Public License (v2.1 or later) and/or GNU
General Public License v2.0 or later and/or Mozilla Public License
1.1", "Unicode strict", "*No copyright* GNU Lesser General Public
License v2.1 or later", "*No copyright* GNU General Public License
v2.0 or later". 130 files have unknown license. Detailed output of
licensecheck in /home/kwizart/7470-makemkv/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[?]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/MakeMKV
[ ]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/256x256,
/usr/share/icons/hicolor/22x22/apps,
/usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/32x32,
/usr/share/icons/hicolor/16x16/apps, /usr/share/MakeMKV,
/usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor,
/usr/share/icons/hicolor/22x22, /usr/share/icons/hicolor/256x256/apps,
/usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/32x32/apps,
/usr/share/icons/hicolor/128x128/apps
[?]: %build honors applicable compiler flags or justifies otherwise.
[-]: Package contains no bundled libraries or specifies bundled libraries
with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[-]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[?]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Maven:
[ ]: If package contains pom.xml files install it (including metadata) even
when building with ant
[x]: Old add_to_maven_depmap macro is not being used
===== SHOULD items =====
Generic:
[!]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0:
https://www.makemkv.com/download/makemkv-oss-1.18.3.tar.gz, Source1:
https://www.makemkv.com/download/makemkv-bin-1.18.3.tar.gz
See: https://docs.fedoraproject.org/en-US/packaging-
guidelines/SourceURL/
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in makemkv-
devel , makemkv-bin
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[!]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
Java:
[-]: Packages are noarch unless they use JNI
Note: makemkv subpackage is not noarch. Please verify manually
[?]: Package uses upstream build method (ant/maven/etc.)
===== EXTRA items =====
Generic:
[!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see
attached diff).
See: (this test has no URL)
[?]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Note: Arch-ed rpms have a total of 5560320 bytes in /usr/share
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: makemkv-1.18.3-1.fc45.x86_64.rpm
makemkv-devel-1.18.3-1.fc45.x86_64.rpm
makemkv-bin-1.18.3-1.fc45.x86_64.rpm
makemkv-1.18.3-1.fc45.src.rpm
============================ rpmlint session starts
============================
rpmlint: 2.8.0
configuration:
/usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmppnaargx2')]
checks: 32, packages: 4
makemkv.src: E: spelling-error ('transcoding', 'Summary(en_US) transcoding ->
trans coding, trans-coding, transcending')
makemkv.src: E: spelling-error ('decrypting', '%description -l en_US decrypting
-> decryption, encrypting')
makemkv.src: E: spelling-error ('transcoding', '%description -l en_US
transcoding -> trans coding, trans-coding, transcending')
makemkv.src: E: spelling-error ('libbluray', '%description -l en_US libbluray
-> library')
makemkv.x86_64: E: spelling-error ('transcoding', 'Summary(en_US) transcoding
-> trans coding, trans-coding, transcending')
makemkv.x86_64: E: spelling-error ('decrypting', '%description -l en_US
decrypting -> decryption, encrypting')
makemkv.x86_64: E: spelling-error ('transcoding', '%description -l en_US
transcoding -> trans coding, trans-coding, transcending')
makemkv.x86_64: E: spelling-error ('libbluray', '%description -l en_US
libbluray -> library')
makemkv.x86_64: W: no-manual-page-for-binary makemkv
makemkv.x86_64: W: no-manual-page-for-binary mmccextr
makemkv.x86_64: W: no-manual-page-for-binary mmgplsrv
makemkv-bin.x86_64: W: no-manual-page-for-binary makemkvcon
makemkv-bin.x86_64: W: no-manual-page-for-binary sdftool
makemkv.x86_64: W: no-documentation
makemkv-bin.x86_64: W: no-documentation
makemkv-devel.x86_64: W: no-documentation
makemkv.src: W: invalid-license Proprietary
makemkv.x86_64: W: invalid-license Proprietary
makemkv-bin.x86_64: W: invalid-license Proprietary
makemkv-devel.x86_64: W: invalid-license Proprietary
makemkv-devel.x86_64: E: incorrect-fsf-address /usr/include/driveio/driveio.h
makemkv-devel.x86_64: E: incorrect-fsf-address /usr/include/driveio/error.h
makemkv-devel.x86_64: E: incorrect-fsf-address /usr/include/driveio/scsicmd.h
makemkv-devel.x86_64: E: incorrect-fsf-address /usr/include/driveio/scsihlp.h
makemkv-devel.x86_64: E: incorrect-fsf-address /usr/include/libmmbd/mmbd.h
4 packages and 0 specfiles checked; 13 errors, 12 warnings, 32 filtered, 13
badness; has taken 1.9 s
Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts
============================
rpmlint: 2.9.0
configuration:
/usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
makemkv.x86_64: E: spelling-error ('transcoding', 'Summary(en_US) transcoding
-> trans coding, trans-coding, transcending')
makemkv.x86_64: E: spelling-error ('transcoding', '%description -l en_US
transcoding -> trans coding, trans-coding, transcending')
makemkv.x86_64: E: spelling-error ('libbluray', '%description -l en_US
libbluray -> library')
makemkv.x86_64: W: no-manual-page-for-binary makemkv
makemkv.x86_64: W: no-manual-page-for-binary mmccextr
makemkv.x86_64: W: no-manual-page-for-binary mmgplsrv
makemkv-bin.x86_64: W: no-manual-page-for-binary makemkvcon
makemkv-bin.x86_64: W: no-manual-page-for-binary sdftool
makemkv.x86_64: W: no-documentation
makemkv-devel.x86_64: W: no-documentation
makemkv-bin.x86_64: W: no-documentation
makemkv.x86_64: W: invalid-license Proprietary
makemkv-devel.x86_64: W: invalid-license Proprietary
makemkv-bin.x86_64: W: invalid-license Proprietary
makemkv-devel.x86_64: E: incorrect-fsf-address /usr/include/driveio/driveio.h
makemkv-devel.x86_64: E: incorrect-fsf-address /usr/include/driveio/error.h
makemkv-devel.x86_64: E: incorrect-fsf-address /usr/include/driveio/scsicmd.h
makemkv-devel.x86_64: E: incorrect-fsf-address /usr/include/driveio/scsihlp.h
makemkv-devel.x86_64: E: incorrect-fsf-address /usr/include/libmmbd/mmbd.h
3 packages and 0 specfiles checked; 8 errors, 11 warnings, 28 filtered, 8
badness; has taken 1.1 s
Requires
--------
makemkv (rpmlib, GLIBC filtered):
libQt5Core.so.5()(64bit)
libQt5Core.so.5(Qt_5)(64bit)
libQt5Core.so.5(Qt_5.15)(64bit)
libQt5DBus.so.5()(64bit)
libQt5DBus.so.5(Qt_5)(64bit)
libQt5Gui.so.5()(64bit)
libQt5Gui.so.5(Qt_5)(64bit)
libQt5Widgets.so.5()(64bit)
libQt5Widgets.so.5(Qt_5)(64bit)
libavcodec.so.62()(64bit)
libavcodec.so.62(LIBAVCODEC_62)(64bit)
libavutil.so.60()(64bit)
libavutil.so.60(LIBAVUTIL_60)(64bit)
libc.so.6()(64bit)
libcrypto.so.4()(64bit)
libcrypto.so.4(OPENSSL_4.0.0)(64bit)
libexpat.so.1()(64bit)
libexpat.so.1(LIBEXPAT_1.0.0)(64bit)
libexpat.so.1(LIBEXPAT_1.1.0)(64bit)
libexpat.so.1(LIBEXPAT_1.95.0)(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
libm.so.6()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libstdc++.so.6(CXXABI_1.3.8)(64bit)
libstdc++.so.6(CXXABI_1.3.9)(64bit)
libz.so.1()(64bit)
libz.so.1(ZLIB_1.2.0)(64bit)
makemkv-bin
rtld(GNU_HASH)
makemkv-devel (rpmlib, GLIBC filtered):
makemkv-bin (rpmlib, GLIBC filtered):
libc.so.6()(64bit)
libdriveio.so.0()(64bit)
libmakemkv.so.1()(64bit)
rtld(GNU_HASH)
Provides
--------
makemkv:
application()
application(makemkv.desktop)
bundled(libdvdnav)
bundled(libdvdread)
bundled(libebml)
bundled(libmatroska)
libdriveio.so.0()(64bit)
libmakemkv.so.1()(64bit)
libmmbd.so.0()(64bit)
makemkv
makemkv(x86-64)
metainfo()
metainfo(makemkv.metainfo.xml)
makemkv-devel:
libdriveio-devel
libmmbd-devel
makemkv-devel
makemkv-devel(x86-64)
makemkv-bin:
makemkv-bin
makemkv-bin(x86-64)
Diff spec file in url and in SRPM
---------------------------------
--- /home/kwizart/7470-makemkv/srpm/makemkv.spec 2026-07-10
10:31:34.165756060 +0200
+++ /home/kwizart/7470-makemkv/srpm-unpacked/makemkv.spec 2026-05-26
02:00:00.000000000 +0200
@@ -1,2 +1,12 @@
+## START: Set by rpmautospec
+## (rpmautospec version 0.8.4)
+## RPMAUTOSPEC: autorelease, autochangelog
+%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
+ release_number = 1;
+ base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
+ print(release_number + base_release_number - 1);
+}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
+## END: Set by rpmautospec
+
# The proprietary portion of MakeMKV does not include debug symbols
%global debug_package %{nil}
@@ -118,3 +128,6 @@
%changelog
-%autochangelog
+## START: Generated by rpmautospec
+* Tue May 26 2026 John Doe <[email protected]> - 1.18.3-1
+- Uncommitted changes
+## END: Generated by rpmautospec
Jar and class files in source
-----------------------------
./makemkv-1.18.3-build/makemkv-1.18.3/makemkv-bin-1.18.3/src/share/blues.jar
Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/usr/bin/fedora-review --other-bz https://bugzilla.rpmfusion.org
-b 7470
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Shell-api, Generic, Java
Disabled plugins: fonts, PHP, Python, Haskell, SugarActivity, Ocaml, Perl, R
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
He are few comments (in addition to the previous formal review).
1/ At fist sight, I thought that having both makemkv-oss and bin into the same
package would ease things as appropriate, but on a second thought you are
disabling strip and debug package for both oss and bin part. So I wonder if
that can be improved ?
Having both packages separated (makemkv-oss and makemkv) could help to rebuild
only the oss part when needed.
2/ License is complex, but all in all I'm not sure to understand how a GPLv2+
libdvdnav/read libraries can be used indirectly within a proprietary software.
So it might makes sense to split RPM packages in order to keep licensing barely
acceptable. (for the same reason upstream provides two separate tarballs).
Basically having a separate makemkv-oss package would allow to consider it like
a combined work, so makemkv(-bin) could use it without inheriting the GPL
requirements.
This is still arguable, but probably is the current status quo on the topic...
3/ There are few hints in the formal review that needs fixes, I will details
once the new packages are split.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug._______________________________________________
rpmfusion-developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]
