https://bugzilla.rpmfusion.org/show_bug.cgi?id=7470
--- Comment #4 from Bradan Fleming <[email protected]> ---
(In reply to Nicolas Chauvet from comment #3)
Spec URL:
https://codeberg.org/bradan/rpm-spec/raw/commit/dc99e5ac39d8ac290c8426e0aa3a0314bd781900/makemkv-bin/makemkv-bin.spec
SRPM URL: https://bradan.ca/tmp/makemkv-bin-1.18.4-1.fc44.src.rpm
Pardon the delay. I've renamed this package to "makemkv-bin" and created a new
review request for "makemkv-oss". I also packaged the libraries separately
because libmmbd has a runtime dependency on makemkvcon and the rest don't. The
new dependency layout seems to work fine when I tested it on my machine.
Review request for makemkv-oss:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=7509
The package layout is now as follows:
- makemkv-bin: The makemkvcon / sdftool binary. Depends on makemkv-oss,
libmakemkv, and libdriveio. Recommends makemkv-blues and libmmbd as they are
needed for full functionality.
- makemkv-blues(-javadoc): The optional GPL blues component. Depends on
makemkv-bin.
- makemkv-oss: mmccextr (ccextractor fork), mmgpl (GPL glue code)
- makemkv: The GUI for MakeMKV and main package for people to install.
Depends on makemkv-bin.
- libmakemkv(-devel): MKV library / wrapper. No dependencies.
- libdriveio(-devel): Drive interrogation API. No dependencies.
- libmmbd(-devel): Decryption API that can be used for UHD disc
playback in VLC / MPV. Depends on makemkv-bin.
Other fixes:
- makemkv-blues no longer installs to the Java path although it now depends on
makemkv-bin for the installation directory
- Added missing headers for libmakemkv (installed to /usr/include/libmkv)
- Added noarch to JavaDoc package
Regarding GPL compliance, I noticed that the mmgpl binary is glue code used by
makemkvcon to interface with GPL 2.0 components. I'm not a lawyer, and it
undoubtedly violates the spirit of the license, but my understanding is that it
is technically legal because "mmgpl" is technically a program that can be used
on its own.
The blues.jar sources are bundled with the JAR file. I've pushed them to a
separate git repository here: https://codeberg.org/bradan/blues
rpmlint: 2.8.0
configuration:
/usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 5
makemkv-bin.src: E: spelling-error ('transcoding', 'Summary(en_US) transcoding
-> trans coding, trans-coding, transcending')
makemkv-bin.src: E: spelling-error ('makemkvcon', '%description -l en_US
makemkvcon -> moneymaker')
makemkv-bin.src: E: spelling-error ('sdftool', '%description -l en_US sdftool
-> footstool')
makemkv-bin.x86_64: E: spelling-error ('transcoding', 'Summary(en_US)
transcoding -> trans coding, trans-coding, transcending')
makemkv-blues-javadoc.x86_64: W: package-with-huge-docs 100%
makemkv-bin.x86_64: W: no-manual-page-for-binary makemkvcon
makemkv-bin.x86_64: W: no-manual-page-for-binary sdftool
makemkv-bin.x86_64: W: no-documentation
makemkv-blues.x86_64: W: no-documentation
makemkv-blues.x86_64: E: no-binary
makemkv-blues-javadoc.x86_64: E: no-binary
makemkv-bin.spec: W: no-%check-section
makemkv-bin.spec: W: no-%check-section
makemkv-bin.src: W: invalid-license Proprietary
makemkv-bin.x86_64: W: invalid-license Proprietary
makemkv-blues.x86_64: W: invalid-license Proprietary
makemkv-blues-javadoc.x86_64: W: invalid-license Proprietary
makemkv-blues-javadoc.x86_64: E: incorrect-fsf-address
/usr/share/javadoc/makemkv-blues/legal/LICENSE
--- Comment #5 from Bradan Fleming <[email protected]> ---
Spec URL:
https://codeberg.org/bradan/rpm-spec/raw/commit/6e5f82f84d58fbfca8501523600d981d7f45dc84/makemkv-bin/makemkv-bin.spec
SRPM URL: https://bradan.ca/tmp/makemkv-bin-1.18.4-1.fc44.src.rpm
This is a minor update to loosen the dependency requirements between
makemkv-bin and makemkv-oss. The versions are still updated in lockstep, but
they no longer require the release to be the same.
Changelog:
https://codeberg.org/bradan/rpm-spec/commit/6e5f82f84d58fbfca8501523600d981d7f45dc84#diff-2f1f48a2b9214a943f965dad2a0d2400acd7f869
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
rpmfusion-developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]
