https://bugzilla.rpmfusion.org/show_bug.cgi?id=7470
--- Comment #2 from Bradan Fleming <[email protected]> ---
Thank you for taking the time to review this!
I initially wasn't sure whether or not splitting makemkv-oss into a separate
package would be worth it solely to handle stripping, but I hadn't considered
the license issues regarding GPL and derivative works, so I went ahead and did
it. I also tried to fix what I could, but there are still a few things that
need to be addressed.
Changes:
- Bumped to 1.18.4
- Moved BLUES to a "makemkv-blues" package with a JavaDoc subpackage.
- Set BLUES as a hard dependency for MakeMKV. This allows BLUES to be installed
separately from MakeMKV and included by MakeMKV with a symlink. This will
hopefully make the license situation more acceptable.
- Added missing javapackages-tools dependency to BLUES.
- Added missing Requires to makemkv-devel
- Fixed ownership of /usr/share/MakeMKV
- Split makemkv-oss into separate specfile. However, this creates a circular
dependency, so I'm unsure whether or not to create a separate review ticket for
that because both packages would need to be added simultaneously.
- The makemkv component still unfortunately has the license set to "Proprietary
AND GPL-2.0-or-later" because BLUES is licensed under GPL2+ despite being
included in the makemkv-bin tarball. However, BLUES is a separate standalone
program that MakeMKV executes rather than links to, so I do not think it is as
much of a problem. Moving it to the makemkv-oss package would probably require
repackaging both blues.jar and makemkv-bin-%{version}.tar.gz to prevent
license-incompatible content from being included in the SRPMs, so I'd prefer
not to do that unless it is necessary.
- BLUES now installs to JavaDir. It is still currently bundled, but if it must
be unbundled, any advice on how to go about it would be appreciated. I could
remove it from the package, ship a POM file and try to use Maven to rebuild the
JAR file, or fork BLUES and add a build system, but none of those are ideal.
Spec URL:
https://codeberg.org/bradan/rpm-spec/raw/commit/7678b9268f92409870907cd43d950c2c7eb290ba/makemkv/makemkv.spec
SRPM URL: https://bradan.ca/tmp/makemkv-1.18.4-1.fc44.src.rpm
OSS Spec URL:
https://codeberg.org/bradan/rpm-spec/src/commit/7678b9268f92409870907cd43d950c2c7eb290ba/makemkv-oss/makemkv-oss.spec
OSS SRPM URL: https://bradan.ca/tmp/makemkv-1.18.4-1.fc44.src.rpm
OSS AppInfo URL:
https://codeberg.org/bradan/rpm-spec/src/commit/7678b9268f92409870907cd43d950c2c7eb290ba/makemkv-oss/makemkv.metainfo.xml
--
You are receiving this mail because:
You are on the CC list for the bug._______________________________________________
rpmfusion-developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]
