Dear Dan and Nicolas!
As I said, I posted a revised patch on trac which includes Nicolas' review
patch.
I reinstalled the old crystal pickles and ran
lolita-3:pickle_jar anne$ sage -t -force_lib
"devel/sage/sage/structure/sage_object.pyx"
sage -t -force_lib "devel/sage/sage/structure/sage_object.pyx"
[7.0 s]
----------------------------------------------------------------------
All tests passed!
Total time for all tests: 7.0 seconds
Could you confirm that with the new patch it won't be necessary to update the
pickles?
Thanks,
Anne
On 2/10/11 9:27 AM, Nicolas M. Thiery wrote:
On Wed, Feb 09, 2011 at 02:59:56PM -0800, Anne Schilling wrote:
That being said, this could advocate for keeping CrystalOfTableaux as
a class (using the classcall trick as we had discussed) in order to
maintain backward compatibility on pickles (beside the other
advantages). Anne: I can make a quick patch over yours tomorrow doing
just that if you want.
If you like. What are the other advantages?
Single entry point.
Isn't it currently a pain that one creates a partition using:
sage: p = Partition([3,2,1])
and test if `p` is a partition with:
sage: isinstance(p, sage.combinat.partition.Partition_class)
? The same holds here: a single name to remember, a single gadget to
export, a single gadget for all usage.
If you are making a patch anyway, could you please also fix the 0.5
to 1/2 that you did not like and Integer to int. (I remember that I
first tried with int, but it did not work for me, but then I had not
used Dan's trick).
Done and pushed!
I did a couple improvements here and there (mostly doc). Please
review, and if things are ok, either fold or post on trac.
Cheers,
Nicolas
--
--
You received this message because you are subscribed to the Google Groups
"sage-combinat-devel" group.
To post to this group, send email to sage-combinat-devel@googlegroups.com.
To unsubscribe from this group, send email to
sage-combinat-devel+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/sage-combinat-devel?hl=en.
