> Dear Dan and Nicolas! > > As I said, I posted a revised patch on trac which includes Nicolas' review > patch. > > I reinstalled the old crystal pickles and ran > > lolita-3:pickle_jar anne$ sage -t -force_lib > "devel/sage/sage/structure/sage_object.pyx" > sage -t -force_lib "devel/sage/sage/structure/sage_object.pyx" > [7.0 s] > > ---------------------------------------------------------------------- > All tests passed! > Total time for all tests: 7.0 seconds > > Could you confirm that with the new patch it won't be necessary to update the > pickles?
After the two patches (fresh downloads from trac, to be sure that I have the latest) #10723 and #10632, there are no problems in sage_object.pyx, which is where we would see pickle problems. There are also no failures in any of the crystal files. (I ran sage -t -long *.) I think that you should update the trac description so that the release manager knows that it is not necessary to update the pickle jar. I would propose that I review #10632 and Anne review #10723. But in fact I think the #10623 review is basically done since both Nicolas and I have kibbitzed quite a bit on this patch. Regarding #10485, with the current #10632 there are a couple of doctest failures in: devel/sage-queue/doc/en/thematic_tutorials/lie/affine_crystals.rst (line 62) devel/sage-queue/doc/en/thematic_tutorials/lie/crystals.rst (line 353) (I may have some further minor comments about #10485.) Dan -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
