Hi Andrew, 2012/7/30, Andrew Mathas <andrew.mat...@gmail.com>: > I want to review a few patches but I am confused by one point. > > The wiki says that the patch should apply cleanly to the *latest > development release*. What is confusing me is that the patches in the > queue, and those on trac, are typically applied on top of other patches so > I would have guessed that quite often they will not apply cleanly to the > release version with no patches applied. For example, this just happened > when I tried to apply Jason Bandlow's patch > trac_9265_tableaux_categories_jb.patch. On the other hand, this patch does > apply cleanly from the queue. > > Question: do you bounce the patch back to the author in this situation? > Similarly, when you are writing patches how do you avoid this?
Dependencies should be used in trac (it is one of the field in the definition of the ticket and consists an a (possibly empty) sequence of patches). An example at [1]. When a patch is ready in sage-combinat it should apply cleanly on the top of the "needs-review" part of the series file. Then, if needed, you specify on the trac ticket that your patch needs to be applied after some others in the dependencies field. [1] http://trac.sagemath.org/sage_trac/ticket/10132 Best Vincent -- You received this message because you are subscribed to the Google Groups "sage-combinat-devel" group. To post to this group, send email to sage-combinat-devel@googlegroups.com. To unsubscribe from this group, send email to sage-combinat-devel+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sage-combinat-devel?hl=en.
