On Thursday, November 16, 2023 at 6:48:47 AM UTC-8 Eric Gourgoulhon wrote:

[...] the file
SAGE_ROOT/build/pkgs/pillow/spkg-install.in
contains the line:

PILLOW_CONFIG_SETTINGS="-C debug=true -C jpeg=disable 
$PILLOW_CONFIG_SETTINGS"

Is there any reason for "jpeg=disable" ? 


This was done in 2016, see 
https://github.com/sagemath/sage/issues/20021#issuecomment-1417764945, 
apparently for platform support reasons

Providing PIL without jpeg support seems quite weird...


I agree
 

This issue is not new and was already noticed already 5 years ago:
https://ask.sagemath.org/question/43298

A side effect of this is that the IPyhon  rendering of PIL Images via the 
rich output mechanism is broken in Sage 10.2.rc3 (but, for some reasons, 
not in Sage 10.1)


This temporarily worked accidentally because Pillow had made an 
incompatible change to the format of its configuration settings. I repaired 
that as part of the Pillow 10 upgrade 
in https://github.com/sagemath/sage/pull/36320
 

If we agree to restore jpeg support in Pillow, I have prepared a branch 
that does this for Sage 10.2 (simply suppressing the option "jpeg=disable"):
https://github.com/egourgoulhon/sage/tree/pillow_jpeg
and I am happy to submit a PR for this.


Yes, please. 

 

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/3ff29e9e-3e10-4630-94b4-5d061e99f82fn%40googlegroups.com.

Reply via email to