Apologies for the basic question in this thread, but recently I have seen lots of conversation about the different labels and I want to clarify something for myself.
In the past few PR I have made for Sage, randomised testing has uncovered (usually) trivial bugs. I then write new PRs to fix these bugs. If there is code causing CI failure in random testing, should I mark the fix for this as a "blocker", even if the chance of this failure is small? I don't want to be melodramatic in my PR for fixes but I also want to make sure I'm labelling things as expected, On Wednesday, February 28, 2024 at 6:08:20 AM UTC David Roe wrote: > On Wed, Feb 28, 2024 at 1:01 AM Kwankyu Lee <ekwa...@gmail.com> wrote: > >> Thank you for making progress on these urgent issues. I suggest the >> following: >> >> 1. Open two other new threads, each of which is for voting on each >> proposal. >> 2. On a proposal, it should be clear that *a positive vote (+1) is for >> the whole proposal,* and if one is negative to any part of the proposal, >> (s)he should give a negative vote (-1). >> > > Voting threads seem reasonable. I'll wait a day or two to see if people > have any final comments before voting. > > >> 3. A proposal is accepted if the number of positive votes is at least >> twice of the number of the negative votes. >> > > Despite the fact that we're asking for this threshold in voting on a PR, > the standard for votes on proposals on sage-devel is just a plain majority > (though of course I hope that we can come to a 2-1 consensus!). > > A minor suggestion for Proposal 2: for the label to be readable, I suggest >> "CI fix" for the name of the label (a blank between words). >> > > I'm happy to adjust the label to be "CI fix." > > >> We may use this thread to get more comments on the Proposals before >> opening voting threads. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sage-devel" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to sage-devel+...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/sage-devel/554961a0-4ace-4317-bfcf-55b6a128bcden%40googlegroups.com >> >> <https://groups.google.com/d/msgid/sage-devel/554961a0-4ace-4317-bfcf-55b6a128bcden%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/b84b22d2-9b57-460c-9f8d-5f8ebe2f982en%40googlegroups.com.
