Hi Michael,

On Wed, Apr 22, 2009 at 5:09 PM, mabshoff <mabsh...@googlemail.com> wrote:
>
> Hi folks,
>
> it would be good if you contributed a feature to Sage 3.4.1 to check
> the release tour at
>
>   http://wiki.sagemath.org/sage-3.4.1
>
> and edit what is there already in case it can be improved or add
> something in case it is missing.
>
> Minh: You seem to list both author[s] and reviewer[s] for credit, but
> it seems better to either only list the author or make clear who author
> [s] and reviewer[s] were. I see that Martin Albrecht already changed
> that for one ticket and I think he is correct.

My policy thus far is to list the author(s) of the patch(es). The case
you mentioned above was a result of me misreading ticket #5146. This
is because for the patch variety_patch.3.patch, I saw the description
"Updated with some of Martin's comments" so I assumed that Martin had
some direct input. I tried to be generous in attributing credit.

-- 
Regards
Minh Van Nguyen

--~--~---------~--~----~------------~-------~--~----~
To post to this group, send email to sage-devel@googlegroups.com
To unsubscribe from this group, send email to 
sage-devel-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URLs: http://www.sagemath.org
-~----------~----~----~----~------~----~------~--~---

Reply via email to