Jaap Spies wrote:
Dr. David Kirkby wrote:
Could #7818 get a positive review, be dropped into alpha2, and let Jaap
Spies get on with the port to Open Solaris? I very much doubt most
people will notice any difference whatsoever, but it will make the
Solaris port a lot easier, and allow for some spkg-install files to be
cleaned up.
Yes, please! I can give it a positive review anyway :).
Jaap
I think given several people have tested it, its not broken on any of the builds
William showed at
http://boxen.math.washington.edu/home/wstein/farm/out/4.3.1.alpha0/
and the fact it would help a lot for Solaris, would be an argument for it
getting a positive.
But then I guess everyone wants their patches to have positive reviews. Some are
more useful than others though. I've submitted a few patches which might just
improve Sage in the distant future. But in this case, the patch can have a major
benefit now, at virtually no risk to anyone.
I've been very conservative with the changes. There might be arguments to add
-m64 (for gcc) to LDFLAGS when SAGE64 is yes, but I am not 100% sure that would
be safe in every circumstance. Hence I did not do it, though if proved to be
100% safe, it would be an improvement, as some bits of sage set LDFLAGS, but
other bits do not.
Dave
--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org