> I suspect the ONLY sensible way to do that would be to drop in new
> Singular, delete all record of all the patches to singular package, and
> create new patches as and when needed.

You suspect wrong. A new Singular SPKG is available in the ticket I referenced 
in this thread which takes care of almost every of those patches. 

<ship>
> I doubt many of these issues have been reported upstream.

Again you are wrong.  ALMOST ALL these issues (except one) have been reported 
upstream and ALL of them have been accepted upstream making our patches 
unnecessary.

The one remaining issue is:

--- ../src/factory/assert.h     2009-11-02 10:12:22.000000000 +0000
+++ assert.h    2010-01-25 18:05:19.164005794 +0000
@@ -127,3 +127,13 @@
 #define PVIRT_CHARCC(msg) = 0
 #endif /* NOASSERT */
 /* }}} */
+
+
+
+/* SAGE hack: This is *critically* needed to compile on some systems
+   for which the logic above is broken.   Obviously it defeates the
+   purpose of assert here, but at least it means that the code compiles.
+*/
+#ifndef assert
+#define assert
+#endif

While it is a bit vague which these systems are at least it is sufficiently 
documented why it is there. I'm confident we can remove this patch at Sage 
Days in Kaiserslautern where the likely author of that patch (William), the 
Singular team and myself (the maintainer of said SPKG) will be present.

Martin


-- 
name: Martin Albrecht
_pgp: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x8EF0DC99
_otr: 47F43D1A 5D68C36F 468BAEBA 640E8856 D7951CCF
_www: http://www.informatik.uni-bremen.de/~malb
_jab: martinralbre...@jabber.ccc.de

-- 
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to 
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org

Reply via email to