On 10/18/11 3:05 PM, Jason Grout wrote:

I see a patch queue for the sagenb.org sagenb install:

google_analytics.patch

I'll add this just to the sagenb notebook.

jsmath_in_published

This is already in the new notebook

figure_out_nt_sagenb_infinite_recursion-rebase.patch

Parts of this are already in the notebook. There are also two additions dealing with worksheet _last_basic. I've looked at how this works, and can't make sense of these changes:

diff --git a/sagenb/storage/filesystem_storage.py b/sagenb/storage/filesystem_storage.py
--- a/sagenb/storage/filesystem_storage.py
+++ b/sagenb/storage/filesystem_storage.py
@@ -333,7 +333,7 @@
         """
         username = worksheet.owner(); id_number = worksheet.id_number()
         basic = self._worksheet_to_basic(worksheet)
- if not hasattr(worksheet, '_last_basic') or worksheet._last_basic != basic: + if not hasattr(worksheet, '_last_basic') or worksheet._last_basic is not basic:
             # only save if changed
self._save(basic, self._worksheet_conf_filename(username, id_number))
             worksheet._last_basic = basic

The 'basic' object here should be a new dictionary every time, so this if should always execute with the "is not basic" line. Is that is what is wanted?

Interestingly, this line is not in the version of the patch not labeled -rebase, so I question the usefulness of this line.

increase_number_of_threads.patch

This patch contains no changes.


customize_login_page.patch

I've committed these acknowledgements to the notebook and added the UTMOST grant number.

Thanks,

Jason

--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to 
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org

Reply via email to